Add tests for numpy hstack and vstack utilities - #46
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for numpy utility functions hstack and vstack in the pyunitwizard library. The tests validate unit conversions, different value type outputs, and error handling for invalid parameters.
- Adds test coverage for
vstackfunction including numpy array shape validation, tuple value type conversion, and invalid value type error handling - Adds test coverage for
hstackfunction including unit conversion validation, list value type conversion, and invalid value type error handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/utils/numpy/test_vstack.py | New test file with 3 test cases covering vstack functionality including shape validation, tuple conversion, and error handling |
| tests/utils/numpy/test_hstack.py | New test file with 3 test cases covering hstack functionality including unit conversion, list conversion, and error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d5c25366688326a6947f58b8081239